Potential fix to parcel bundling issues when asset parent & commonBundle types differ #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#294 #326
This PR potentially fixes the issues mentioned above. It does the following
case (i):
If the below is true => i.e both types are the same (parent Bundle is JS and commonBundle is also JS) move it the common ancestor.
case 2:
If they aren't the same, for eg: parentBundle is JS and commonBundle is HTML. Then allow it to continue further so that it adds this asset to the immediate parent.
case 3:
If both parent bundles are equal, then just return.