Resolve "module", "jsnext:main" and "browser" before "main" #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e72a4a to
d9be8dd
Compare
devongovett
approved these changes
Dec 20, 2017
|
Would be good to add a test for this! Would you like to follow up with that @fathyb? Thanks! |
|
I'll make another PR for the tests later today. I also found a bug a few minutes ago where some libraries define an object inside of module, I'll make another to prevent that 😅 |
Closed
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for a lot of libraries who ship their Node.js version in the
mainfield (see #298). This will also use the ES6 modules version of some libraries (instead of UMD) and might lead to a better bundling/sharing of dependencies.