Shake exports with pure property assignments #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d348e7b to
15680c2
Compare
mischnic
previously approved these changes
May 6, 2019
| @@ -85,7 +76,8 @@ function isExportAssignment(path) { | |||
| // match "path.any = any;" | |||
| path.parentPath.isMemberExpression() && | |||
| path.parentPath.parentPath.isAssignmentExpression() && | |||
| path.parentPath.parentPath.node.left === path.parentPath.node | |||
| path.parentPath.parentPath.node.left === path.parentPath.node && | |||
| path.parentPath.parentPath.get('right').isPure() | |||
There was a problem hiding this comment.
Should rather be called isExportAssignmentPure now?
There was a problem hiding this comment.
actually... I think this check is unnecessary now
| @@ -122,6 +114,15 @@ function remove(path) { | |||
| } else if (isUnusedWildcard(path)) { | |||
| remove(path.parentPath); | |||
| } else if (!path.removed) { | |||
| path.remove(); | |||
| if ( | |||
There was a problem hiding this comment.
The code duplication isn't ideal but I don't see a cleaner way without doing some extra if checks
twome
added a commit
to twome/parcel
that referenced
this pull request
May 12, 2019
…e/strip-type-module-attr * 'master' of github.com:parcel-bundler/parcel: Update deps & gitattributes (parcel-bundler#3006) Fix assigning to exports from inside a function in scope hoisting (parcel-bundler#2994) Define __esModule interop flag when requiring ES module from CommonJS (parcel-bundler#2993) Replace module.require in scope hoisting (parcel-bundler#2875) Clear scope cache before crawling (parcel-bundler#2986) Fix CI (parcel-bundler#2990) Shake exports with pure property assignments (parcel-bundler#2979) Update postcss.js (parcel-bundler#2922) Fail immediately if yarn.lock updates are needed (parcel-bundler#2945) # Conflicts: # packages/core/parcel-bundler/package.json # yarn.lock
twome
added a commit
to twome/parcel
that referenced
this pull request
Sep 10, 2019
…e/strip-type-module-attr * 'master' of github.com:parcel-bundler/parcel: fix source maps on coffeescript assets (parcel-bundler#3423) Fixes parcel-bundler#3133 by upgrading serialize-to-js from 1.1.1 to 3.0.0 (parcel-bundler#3451) Fix up misleading usage information (parcel-bundler#3158) bump chokidar to get a reload fix for linux (parcel-bundler#2878) Use uppercase for the first letter of the issue template (parcel-bundler#3192) Update dotenv-expand to allow overriding of falsy values (parcel-bundler#2971) Fixes 3076: HMR update breaks in webworker due to window (and location.reload) not existing in web worker context. (parcel-bundler#3078) Scope hoisting destructuring (parcel-bundler#2742) Create FUNDING.yml (parcel-bundler#3074) Added new info command (parcel-bundler#3068) Fix typo (parcel-bundler#3043) Update deps & gitattributes (parcel-bundler#3006) Fix assigning to exports from inside a function in scope hoisting (parcel-bundler#2994) Define __esModule interop flag when requiring ES module from CommonJS (parcel-bundler#2993) Replace module.require in scope hoisting (parcel-bundler#2875) Clear scope cache before crawling (parcel-bundler#2986) Fix CI (parcel-bundler#2990) Shake exports with pure property assignments (parcel-bundler#2979) Update postcss.js (parcel-bundler#2922) Fail immediately if yarn.lock updates are needed (parcel-bundler#2945)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2909.
For example, assigning a
displayNameto a function is pretty common in react code, and does not cause side effects.