Fix relative paths in CSS (take 2) #2770
Conversation
| .getAsset(resolved, this.options) | ||
| .generateBundleName(); | ||
|
|
||
| parsed.pathname = path.relative(path.dirname(this.relativeName), name); |
There was a problem hiding this comment.
name is always just a hash+extension, so this relative call doesn't really do anything useful.
Here's a repo where it still isn't working (the error resurfaced I tried to fix the original relative PR): https://github.com/mischnic/2736-svg-import
In the dist root, a CSS file contains url('../logo_color.78fe8740.svg');.
(I also think this should be path.posix.relative to not generate backslashes on Windows.)
There was a problem hiding this comment.
the test for CSS that I updated fails without this line...
There was a problem hiding this comment.
This is the core problem in the repo I linked above:
Relative name of asset: a/style.css. A URL Dependency is in the outputDir root, so ../logo_color.78fe8740.svg seems correct.
Actually, a/style.css gets put into the root as well (does the Asset know this or only the Packager?) and now the ../ part is wrong.
There was a problem hiding this comment.
ahhh you're right. I guess we cannot correctly generate the relative path.
This is take 2 of #2740. It changes
addURLDependencyto return a relative path, fixes the test to resolve the asset relative to the css file, and adds a test for importing a raw asset in JS in a subdirectory.Fixes #2736. Closes #2740.