Fix sourceMappingURL for bundles with multiple entry points #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lustoykov
commented
Feb 14, 2019
| @@ -239,7 +239,7 @@ class JSPackager extends Packager { | |||
| if (mapBundle) { | |||
| let mapUrl = urlJoin( | |||
| this.options.publicURL, | |||
| path.basename(mapBundle.name) | |||
| path.relative(this.options.outDir, mapBundle.name) | |||
There was a problem hiding this comment.
only change is here, rest are tests
c0eff27 to
30627a1
Compare
devongovett
approved these changes
Feb 17, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
sourceMappingURL is not correct for bundles with multiple entry points
💻 Examples
Taken from #2607
The two output files should contains these sourcemap comments:
but in reality
/a/and/b/are not there.🚨 Test instructions
See #2607 for detailed instructions. For tldr, see Examples 👆
✔️ PR Todo