Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and apply stripping flow types #1864

Merged
merged 9 commits into from
Aug 23, 2018
Merged

Detect and apply stripping flow types #1864

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
98dbe99
detect and apply stripping flow types
DeMoorJasper Aug 8, 2018
9511e97
add test
DeMoorJasper Aug 8, 2018
9301f5e
improve test
DeMoorJasper Aug 8, 2018
48bff7e
performance improvement
DeMoorJasper Aug 8, 2018
3e5a158
using Reg.test and also use on source
DeMoorJasper Aug 23, 2018
d10df94
merge
DeMoorJasper Aug 23, 2018
ac94de4
merge configs
DeMoorJasper Aug 23, 2018
73c46c0
reorder flow check
DeMoorJasper Aug 23, 2018
e74e92e
fix missing dep
DeMoorJasper Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/transforms/babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,10 @@ async function getJSXConfig(asset, isSourceModule) {
* Generates a babel config for stripping away Flow types.
*/
function getFlowConfig(asset, isSourceModule) {
if (!isSourceModule && asset.contents.includes('@flow')) {
if (
!isSourceModule &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the inverse? Wouldn't we want to enable flow on app code and locally linked modules? I'm not sure enabling it on published node_modules is a good idea. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is published code, as they shouldn't ship with flow types, local code should follow babelrc.

Shipped code should probably use flow comments or seperate .flow files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a nice feature to enable flow automatically on source code just like we do for JSX.

Shipped code should generally be pre-transpiled to remove the types I thought... Not sure, I guess it doesn't hurt to automatically do it for everything.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, but apparently not every module does it as you can see in the linked issue

asset.contents.substring(0, 20).indexOf('@flow') > -1
Copy link
Member Author

@DeMoorJasper DeMoorJasper Aug 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jsperf.com/includes-vs-substring-includes-vs-indexof/1 Performance test for this line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ensure that this is inside a comment? like look for // @flow or something?

Copy link
Member Author

@DeMoorJasper DeMoorJasper Aug 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that it can be // @flow or /* @flow */ or any other variation of comment. So either we'd have to use a regex or do a babel walk to just detect this. Which would probably slow things down.

I can change it to a regex or babel walk just not sure about performance (Probably regex).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah a regex would be ok (on the substring). Should be fast enough.

) {
return {
plugins: [[require('babel-plugin-transform-flow-strip-types')]],
internal: true
Expand Down
2 changes: 1 addition & 1 deletion test/javascript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1347,7 +1347,7 @@ describe('javascript', function() {
assert(output.includes('Other page'));
});

it.only('should strip away flow types of node modules', async function() {
it('should strip away flow types of node modules', async function() {
let b = await bundle(
__dirname + '/integration/babel-strip-flow-types/index.js'
);
Expand Down