Fix glob import/require in Stylus assets #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
approved these changes
Aug 3, 2018
|
Awesome, thanks for this! |
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said in #1816, Parcel currently overrides the Stylus resolver with its own, namely to support importing from
node_modulesand root imports. However, it currently fails to resolve glob imports, trying to resolve to files literally named**/*(which obviously don't exist, throwingENOENT).This PR works around the issue by detecting glob imports in the ahead-of-time Stylus
ImportVisitor, applyingfast-globon the given path, and then associating multiple paths to the import instead of a single one.During evaluation time, it will then replace the glob import statement with multiple ones (one for each resolved file) before passing them to Stylus, and then merging all the resulting node blocks into one.
This PR also adds a test case for Stylus glob import, to prevent future regressions.
This should fix #1816.
(Comments are obviously welcome, considering I don't really know the Parcel codebase there might be issues here and there.)