feat(builtins): load min versions if available #1741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
requested changes
Jul 16, 2018
bf2843f to
bedbcfd
Compare
|
@DeMoorJasper I created a file |
bedbcfd to
27b1897
Compare
src/packagers/JSConcatPackager.js
Outdated
| fs | ||
| .readFileSync(path.join(__dirname, '../builtins/helpers.js'), 'utf8') | ||
| .trim() + '\n'; | ||
| const prelude = getExisting(path.join(__dirname, '../builtins/prelude2')); |
There was a problem hiding this comment.
Sorry for being difficult, but I'd prefer this to be more explicit.
Use the full paths, because this overcomplicates it a little in my opinion
There was a problem hiding this comment.
Understood. I did it in a separate commit.
I'll squash after we get this into an approved state.
martell
commented
Jul 17, 2018
src/utils/getExisting.js
Outdated
| * we use min.js and .js (with .js as the minified fallback). | ||
| */ | ||
| module.exports = function(minified, source) { | ||
| if(minified.split('.').length < 2 && source === undefined) { |
There was a problem hiding this comment.
Yeah sure seems obsolete now that you've written them explicitly
6e8d77d to
ae66d69
Compare
|
done, this should be good to go. I also squashed it. |
DeMoorJasper
approved these changes
Jul 17, 2018
src/packagers/JSPackager.js
Outdated
| .replace(/;$/, '') | ||
| }; | ||
| const prelude = getExisting( | ||
| path.join(__dirname, '../builtins/prelude.min.js') |
There was a problem hiding this comment.
It appears you forgot a , here though
ae66d69 to
db168d7
Compare
DeMoorJasper
requested changes
Jul 17, 2018
DeMoorJasper
requested changes
Jul 17, 2018
DeMoorJasper
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helpers.js prelude2.js and prelude.js don't have min versions in git tree.
I think we should have a fallback these instead of blindly checking for the minified versions.
(For when someone wants to use master directly for testing in their package.json instead of using a release bundle)
Thoughts?