Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve absolute URL relative to options.rootDir #1407

Closed
wants to merge 2 commits into from
Closed

Resolve absolute URL relative to options.rootDir #1407

wants to merge 2 commits into from

Conversation

buckle2000
Copy link
Contributor

@buckle2000 buckle2000 commented May 22, 2018 •
edited
Loading

Will not close #1352
Closes #1398

@buckle2000 buckle2000 changed the title Feature/root dir Resolve absolute URL relative to options.rootDir May 22, 2018
@DeMoorJasper
Copy link
Member

DeMoorJasper commented May 22, 2018 •
edited
Loading

Would probably be nice to run these dependencies through the resolver.
This way it resolves both ~/ & /

@DeMoorJasper
Copy link
Member

How does this close #1398 ? This PR doesn't add any flag to the cli?

@buckle2000
Copy link
Contributor Author

#1407 (comment)
What do you mean?

@buckle2000
Copy link
Contributor Author

buckle2000 commented May 22, 2018 •
edited
Loading

#1407 (comment)
After reading the code, I think this should be the default behaviour without any CLI flag. No one will use absolute path resolved to filesystem root.

@DeMoorJasper
Copy link
Member

I meant this: #1324
You're definitely right that this should be the default behaviour though

@DeMoorJasper
Copy link
Member

merged #1324

@Edvinas01 Edvinas01 mentioned this pull request Jul 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@buckle2000 @DeMoorJasper