Lookup correct generated output for bundle type in RawPackager #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an `Asset` generates multiple assets with different types, `RawPackager` would give the same output for every entry in `asset.generated` even if they have different types and values. This is because it used the asset's primary type `asset.type` instead of the type for the bundle it is actually generating (`this.bundle.type`). This fixes it so that `RawPackager` uses the bundle type so that the correct entry in `generated` is read for each bundle.
DeMoorJasper
approved these changes
May 19, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
Assetgenerates multiple assets with different types,RawPackagerwould give the same output for every entry inasset.generatedeven if they have different types and values. This is because it used the asset's primary typeasset.typeinstead of the type for the bundle it is actually generating (this.bundle.type).This fixes it so that
RawPackageruses the bundle type so that the correct entry ingeneratedis read for each bundle.