Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--functional: wait for wrapper to end its operations before destroing the child process #787

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

Slamdunk
Copy link
Member

Fix #786

@Slamdunk Slamdunk added the bug label Aug 29, 2023
@Slamdunk Slamdunk merged commit 7f372b5 into paratestphp:7.x Aug 29, 2023
@Slamdunk Slamdunk deleted the junit_bug_on_functional_tests branch August 29, 2023 07:47
@Slamdunk Slamdunk changed the title --functional: wait for wrapper to end its operations before destroing the chile process --functional: wait for wrapper to end its operations before destroing the child process Aug 29, 2023
// We need to wait for ApplicationForWrapperWorker::end to end
while ($this->workers[$token]->isRunning()) {
usleep(self::CYCLE_SLEEP);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nunomaduro can you apply this fix to Pest too please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Unable to merge junit logs (first worker output empty file)
1 participant