Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade wgpu to 22.0 #402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

clearlysid
Copy link

wgpu versions now use the x.0 rather than the 0.x scheme ie.. 22.0 is the new 0.22.

Unfortunately, Cargo treats these as very different dependencies and versions. This causes the pixels crate to become incompatible with projects that are using a newer version of wgpu for something else.

In this PR, I've upgraded the wgpu version to latest and fixed the relevant API calls with newer args that the compiler mandated (just defaults for now).

Feel free to merge this if you feel this is relevant. Thanks for the great project! 🙌

@parasyte
Copy link
Owner

Yeah, wgpu still needs to be updated. This is a pretty good start, thank you!

I'm holding off any other updates to wgpu until the next release (pixels 0.15) with support for wgpu 0.19. Which still needs some work as discussed in #400.

But I'm glad this has already been started!

@clearlysid
Copy link
Author

Makes total sense!

@parasyte parasyte mentioned this pull request Oct 14, 2024
@mkrasnitski
Copy link
Contributor

One complication with this is the egui example. Support for wgpu v22 was added in egui 0.29, which also bumps winit to 0.30. So, that example would need to be reworked to use the newer winit version. Also, seems like winit_input_helper doesn't yet support winit 0.30. There are some open PRs but nothing has been merged yet.

@parasyte
Copy link
Owner

parasyte commented Jan 18, 2025

See also: #411 and #403

If we are going to be nimble enough to continue updating wgpu in lockstep, we need to move the examples to their own repo. This was discussed a bit in #391 (comment) and I'm increasingly convinced this is the right course of action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants