Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify socket path #192

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Modify socket path #192

merged 1 commit into from
Jul 2, 2020

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Jun 29, 2020

Following the secure deployment guide, modify the socket path to
/tmp/parsec/parsec.sock
Removes socket activation from the systemd unit files. Modifies the
permission of the created socket so that all users who can access the
/tmp/parsec folder can use it.
Adds back the Cargo.lock file which was removed.

Signed-off-by: Hugues de Valon hugues.devalon@arm.com

Type=notify
NonBlocking=true
Environment=RUST_LOG=info
WorkingDirectory=/home/parsec/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we depend on existence of "parsec" user account and its home? What's the reason?

In the Yocto layer, for example, I install parsec binary into ${bindir}/parsec (although we might want to install it into ${sbindir}) and parsec config into /etc/parsec/config.toml

Copy link
Member Author

@hug-dev hug-dev Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we depend on existence of "parsec" user account and its home? What's the reason?

This PR is a draft depending on if we accept the secure deployment guidelines described in parallaxsecond/parsec-book#41
The existence of the parsec user and its home is an easy way to ensure that the above guidelines are respected while installing Parsec as an user systemd service. The systemd files can still be customised by the knowledgable admin during deployment to make it suit better to the target environment.

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hug-dev hug-dev marked this pull request as ready for review July 1, 2020 11:54
@hug-dev hug-dev force-pushed the socket-path branch 2 times, most recently from fcad737 to 7649ecb Compare July 1, 2020 12:06
Following the secure deployment guide, modify the socket path to
/tmp/parsec/parsec.sock
Removes socket activation from the systemd unit files. Modifies the
permission of the created socket so that all users who can access the
/tmp/parsec folder can use it.
Adds back the `Cargo.lock` file which was removed.

Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
@hug-dev hug-dev self-assigned this Jul 2, 2020
@hug-dev hug-dev added enhancement New feature or request security Issues related to the security and privacy of the service labels Jul 2, 2020
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hug-dev hug-dev merged commit 6ca8010 into parallaxsecond:master Jul 2, 2020
@hug-dev hug-dev deleted the socket-path branch July 2, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security Issues related to the security and privacy of the service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants