-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom beacon withdrawals example #9497
Add custom beacon withdrawals example #9497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like we should expose a better API via NodeBuilder for overriding the pre/post hooks more granularly, and for new system contracts, given BSC also uses it
Let me know if I can help with that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
7a9560b
to
eaf8e0d
Compare
eaf8e0d
to
11a2baa
Compare
hey @dapplion thanks a lot for your work! now that #11274 is closed I've taken the opportunity to rebase this PR on top of main and update it to use the new composable executor abstraction with strategies. In the pls take a look and let me know if you have any questions! |
278f21c
to
b9dae4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! lgtm
🎉 thanks for updating it to the custom executor |
Adds an example of modifying a post-block execution step. Specifically, it modifies the beacon withdrawal processing logic: do a system call instead of minting native tokens.
I have made some structs and fns pub to reduce diff. Please let me know if there are more opportunities to minimize the diff. There's duplicated code between this custom executor, the op executor and the eth executor.