Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trie): metrics #6943

Merged
merged 8 commits into from
Mar 4, 2024
Merged

feat(trie): metrics #6943

merged 8 commits into from
Mar 4, 2024

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Mar 3, 2024

Description

Instrument root calculators with general trie metrics.

@rkrasiuk rkrasiuk added A-observability Related to tracing, metrics, logs and other observability tools A-trie Related to Merkle Patricia Trie implementation labels Mar 3, 2024
@rkrasiuk rkrasiuk requested a review from gakonst as a code owner March 3, 2024 16:32
shekhirin
shekhirin reviewed Mar 3, 2024
View reviewed changes
crates/trie/src/metrics.rs

impl TrieRootMetrics {
pub(crate) fn new(ty: TrieType) -> Self {
Self::new_with_labels(&[("type", ty.as_str())])
Copy link
Collaborator

@shekhirin shekhirin Mar 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally, we should cache this initialization, see #6730.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6730 was impactful because metrics initialization was on a hot code path. not the case here, so i wouldn't worry too much

@rkrasiuk rkrasiuk requested review from shekhirin and DaniPopes March 4, 2024 07:57
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/trie-metrics branch from 25e38ab to de036d7 Compare March 4, 2024 09:21
@rkrasiuk rkrasiuk requested a review from shekhirin March 4, 2024 13:04
shekhirin
shekhirin approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nits

crates/trie/Cargo.toml Outdated Show resolved Hide resolved
crates/trie/src/trie.rs Show resolved Hide resolved
@rkrasiuk rkrasiuk enabled auto-merge March 4, 2024 14:22
@rkrasiuk rkrasiuk added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 53e67c2 Mar 4, 2024
30 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/trie-metrics branch March 4, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@mattsse mattsse Awaiting requested review from mattsse

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-trie Related to Merkle Patricia Trie implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkrasiuk @shekhirin @DaniPopes