Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm deposit from pooledtx #6941

Merged
merged 9 commits into from
Mar 5, 2024
Merged

rm deposit from pooledtx #6941

merged 9 commits into from
Mar 5, 2024

Conversation

justcode740
Copy link
Contributor

@justcode740 justcode740 commented Mar 3, 2024 •
edited
Loading

resolves #6915

@justcode740 justcode740 changed the title . rm deposit from pooledtx Mar 3, 2024
@justcode740 justcode740 force-pushed the 0x/rm_deposit_from_pooledtx branch from e3accd9 to 0c46fe9 Compare March 3, 2024 09:06
mattsse
mattsse requested changes Mar 3, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

left a few suggestions

crates/primitives/src/transaction/error.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/error.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/pooled.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/pooled.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/pool/mod.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/error.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/pooled.rs Outdated Show resolved Hide resolved
crates/net/eth-wire/src/types/transactions.rs Outdated Show resolved Hide resolved
@justcode740 justcode740 requested a review from mattsse March 3, 2024 23:20
mattsse
mattsse requested changes Mar 4, 2024
View reviewed changes
crates/net/network/src/transactions/mod.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/pooled.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/pooled.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/pooled.rs Outdated Show resolved Hide resolved
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-tx-pool Related to the transaction mempool labels Mar 4, 2024
@justcode740 justcode740 requested a review from mattsse March 5, 2024 00:06
mattsse
mattsse approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

this is a lot cleaner now

mattsse
mattsse approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

this is a lot cleaner now

@mattsse mattsse added this pull request to the merge queue Mar 5, 2024
Merged via the queue into paradigmxyz:main with commit ec401aa Mar 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove OP deposit tx variant from PooledTransactionElement
2 participants
@justcode740 @mattsse