Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump ethers to 2.0.14, enr to 0.10, unpin discv5 #6634

Merged
merged 13 commits into from
Mar 6, 2024
Merged

chore(deps): bump ethers to 2.0.14, enr to 0.10, unpin discv5 #6634

merged 13 commits into from
Mar 6, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Feb 16, 2024 •
edited by DaniPopes
Loading

Bump enr to latest version.

Closes #6006

@emhane emhane requested a review from gakonst as a code owner February 16, 2024 23:40
Rjected
Rjected approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rjected
Copy link
Member

Rjected commented Feb 16, 2024

ah rip, breaking change, looks like a builder rename

@emhane
Copy link
Member Author

emhane commented Feb 17, 2024

ah rip, breaking change, looks like a builder rename

yepp, I'm on it. tbh, I outsourced compiling to ci this time, but will have new hw soon.

@emhane emhane requested a review from mattsse as a code owner February 17, 2024 00:50
@emhane
Copy link
Member Author

emhane commented Feb 17, 2024

depends on gakonst/ethers-rs#2741

@emhane emhane added the A-dependencies Pull requests or issues that are about dependencies label Feb 17, 2024
@DaniPopes
Copy link
Member

cc #6006

@emhane emhane added the M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity label Feb 17, 2024
@emhane
Copy link
Member Author

emhane commented Feb 17, 2024

waiting now on ethers-rs to cut new release

@Rjected Rjected added the S-blocked This cannot more forward until something else changes label Feb 19, 2024
@DaniPopes DaniPopes mentioned this pull request Mar 6, 2024
Closed
DaniPopes
DaniPopes reviewed Mar 6, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
@DaniPopes DaniPopes changed the title Update enr version chore(deps): bump enr to 0.10 Mar 6, 2024
@DaniPopes DaniPopes changed the title chore(deps): bump enr to 0.10 chore(deps): bump enr to 0.10, unpin discv5 Mar 6, 2024
@DaniPopes DaniPopes changed the title chore(deps): bump enr to 0.10, unpin discv5 chore(deps): bump ethers to 2.0.14, enr to 0.10, unpin discv5 Mar 6, 2024
@DaniPopes DaniPopes removed the S-blocked This cannot more forward until something else changes label Mar 6, 2024
@DaniPopes DaniPopes removed the M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity label Mar 6, 2024
@DaniPopes DaniPopes enabled auto-merge March 6, 2024 18:28
@DaniPopes DaniPopes added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit b66f54d Mar 6, 2024
28 checks passed
@DaniPopes DaniPopes deleted the emhane/update-enr branch March 6, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update enr, discv5 dependencies
4 participants
@emhane @Rjected @DaniPopes @mattsse