Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cancun mainnet timestamp #6493

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat: add cancun mainnet timestamp #6493

merged 2 commits into from
Feb 8, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Feb 8, 2024

Enables cancun on mainnet at timestamp 1710338135

Geth PR: ethereum/go-ethereum#28958

@Rjected Rjected added C-enhancement New feature or request E-cancun Related to the Cancun network upgrade labels Feb 8, 2024
@Rjected Rjected requested a review from gakonst as a code owner February 8, 2024 18:38
mattsse
mattsse approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

@mattsse
Copy link
Collaborator

mattsse commented Feb 8, 2024

ah @Rjected can we add the missing timestamps here

reth/crates/primitives/src/chain/spec.rs

Line 129 in 787c9b1

fork_timestamps: ForkTimestamps::default().shanghai(1677557088),

and

reth/crates/primitives/src/chain/spec.rs

Line 36 in 787c9b1

fork_timestamps: ForkTimestamps::default().shanghai(1681338455),

@Rjected
Copy link
Member Author

Rjected commented Feb 8, 2024

ah @Rjected can we add the missing timestamps here

reth/crates/primitives/src/chain/spec.rs

Line 129 in 787c9b1

fork_timestamps: ForkTimestamps::default().shanghai(1677557088),

and

reth/crates/primitives/src/chain/spec.rs

Line 36 in 787c9b1

fork_timestamps: ForkTimestamps::default().shanghai(1681338455),

just added

@mattsse mattsse enabled auto-merge February 8, 2024 18:54
gakonst
gakonst approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancun mainnet: Wed Mar 13 2024 13:55:35 GMT+0000

^^ LFG

@mattsse mattsse added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit e781a6c Feb 8, 2024
29 checks passed
@mattsse mattsse deleted the dan/cancun-mainnet-timestamp branch February 8, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
C-enhancement New feature or request E-cancun Related to the Cancun network upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rjected @mattsse @gakonst