Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add operator fee params on RPC L1BlockInfo #14269

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Feb 6, 2025

Following alloy-rs/op-alloy#420, this PR handle hydrating operator fee params for RPC receipt.

Blocked by a new op- alloy release including alloy-rs/op-alloy#420

Cargo.toml Outdated
Comment on lines 467 to 474
op-alloy-rpc-types = { version = "0.10.2", default-features = false }
op-alloy-rpc-types-engine = { version = "0.10.2", default-features = false }
op-alloy-network = { version = "0.10.2", default-features = false }
op-alloy-consensus = { version = "0.10.2", default-features = false }
op-alloy-flz = { version = "0.10.2", default-features = false }
op-alloy-rpc-jsonrpsee = { version = "0.10.2", default-features = false }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be updated with a new op-alloy release

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will send this shortly, need to check what else we might need re isthmus, such as:

alloy-rs/op-alloy#418

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, tysm!

blocked until alloy bump

@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Feb 6, 2025
@mattsse mattsse self-assigned this Feb 6, 2025
@emhane emhane added the A-rpc Related to the RPC implementation label Feb 8, 2025
@leruaa leruaa force-pushed the add-operator-fee-params-to-receipt branch from 17d9258 to 71367f7 Compare February 10, 2025 15:18
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @emhane includes alloy bump

@mattsse mattsse marked this pull request as ready for review February 10, 2025 16:52
@mattsse mattsse enabled auto-merge February 10, 2025 16:53
@mattsse mattsse added this pull request to the merge queue Feb 10, 2025
Merged via the queue into paradigmxyz:main with commit d4e37ce Feb 10, 2025
44 checks passed
18aaddy pushed a commit to 18aaddy/reth that referenced this pull request Feb 12, 2025
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants