docs: fix broken links in docs/crates/network.md
#13948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
requested changes
Jan 23, 2025
docs/crates/network.md
Outdated
| @@ -168,7 +168,7 @@ The `Swarm` struct glues together incoming connections from peers, managing sess | |||
|
|
|||
| We'll touch more on the `NetworkManager` shortly! It's perhaps the most important struct in this crate. | |||
|
|
|||
| More information about the discovery task can be found in the [discv4](./discv4.md) chapter. | |||
| More information about the discovery task can be found in the [discv4](https://github.com/ethereum/devp2p/blob/master/discv4.md) chapter. | |||
There was a problem hiding this comment.
We actually removed this section of the book, it might be better to just remove these lines because the reference to the discv4 docs does not really make sense in context
|
Hi @Rjected! Done |
mattsse
approved these changes
Jan 23, 2025
Comment on lines
-11
to
-12
| We'll leave most of the discussion of the discovery task for the [discv4](./discv4.md) chapter, and will focus on the other three here. | ||
|
|
There was a problem hiding this comment.
yep we removed those because no longer useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! In this PR, I updated the broken links in the
network.mdfile to point to the correct pages in the Ethereum repository. The links now properly refer to: