Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latency metrics to eviction pools routines #13946

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yohkaz
Copy link
Contributor

@yohkaz yohkaz commented Jan 23, 2025

(potentially) Closes #6664

@yohkaz yohkaz requested a review from mattsse as a code owner January 23, 2025 10:44
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these calls are very time sensitive

to me the additional clock calls seem alright, wdyt @hai-rise

@hai-rise
Copy link
Contributor

@mattsse I think they are alright, too.

This won't likely affect us as we can buff the mempool size of the centralized sequencer and buffer new transactions instead of truncating when full 🙏.

@emhane emhane added A-tx-pool Related to the transaction mempool A-observability Related to tracing, metrics, logs and other observability tools labels Jan 24, 2025
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice if pr included update grafana dashboard code to use these metrics + a screenshot of how it looks

@yohkaz
Copy link
Contributor Author

yohkaz commented Jan 27, 2025

@emhane I followed this guide to add the new metrics to grafana dashboard: https://github.com/paradigmxyz/reth/blob/main/etc/README.md
for some reason grafana decided to move around existing metrics in the changeset: 56358d4
I think it fixes some position issues of existing panels on the way.
If you know how to avoid this, lmk.

This is how the new metrics look:
EvictionMetricsGrafana

@yohkaz yohkaz requested a review from emhane January 27, 2025 00:30
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. grafana dashboards are tricky to update, they always leave a lot of diff, that's why we separated the dashboard into several different dashboards e.g. one for mempool, one for discovery, etc.

@yohkaz yohkaz requested a review from mattsse January 28, 2025 13:26
@yohkaz
Copy link
Contributor Author

yohkaz commented Jan 30, 2025

@mattsse @hai-rise is there any other concern/request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add eviction latency metrics
4 participants