-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latency metrics to eviction pools routines #13946
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these calls are very time sensitive
to me the additional clock calls seem alright, wdyt @hai-rise
@mattsse I think they are alright, too. This won't likely affect us as we can buff the mempool size of the centralized sequencer and buffer new transactions instead of truncating when full 🙏. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice if pr included update grafana dashboard code to use these metrics + a screenshot of how it looks
@emhane I followed this guide to add the new metrics to grafana dashboard: https://github.com/paradigmxyz/reth/blob/main/etc/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. grafana dashboards are tricky to update, they always leave a lot of diff, that's why we separated the dashboard into several different dashboards e.g. one for mempool, one for discovery, etc.
(potentially) Closes #6664