Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bench): more determinism #13603

Merged
merged 1 commit into from
Dec 31, 2024
Merged

chore(bench): more determinism #13603

merged 1 commit into from
Dec 31, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Dec 31, 2024 •
edited
Loading

Closes #13535

@DaniPopes DaniPopes enabled auto-merge December 31, 2024 00:40
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 31, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #13603 will improve performances by 80.23%

Comparing dani/more-deterministic-benches (8da1db5) with main (e9332f9)

Summary

⚡ 10 improvements
✅ 67 untouched benchmarks

Benchmarks breakdown

Benchmark main dani/more-deterministic-benches Change
⚡ `validate_blob num blobs: 1 ValidateBlob` 23.4 µs
⚡ `validate_blob num blobs: 2 ValidateBlob` 23.5 µs
⚡ `validate_blob num blobs: 3 ValidateBlob` 23.4 µs
⚡ `validate_blob num blobs: 4 ValidateBlob` 23.6 µs
⚡ `validate_blob num blobs: 5 ValidateBlob` 23.6 µs
⚡ `sparse trie[init size 1000 update size 100 num updates 1]` 1.4 ms
⚡ `sparse trie[init size 10000 update size 100 num updates 1]` 4.7 ms
⚡ `sparse trie[init size 10000 update size 100 num updates 3]` 9.7 ms
⚡ `sparse trie[init size 10000 update size 100 num updates 5]` 14.6 ms
⚡ `sparse trie[init size 10000 update size 1000 num updates 1]` 14.5 ms

@DaniPopes DaniPopes force-pushed the dani/more-deterministic-benches branch from 11d526d to fcdcb8d Compare December 31, 2024 00:53
@DaniPopes DaniPopes force-pushed the dani/more-deterministic-benches branch from fcdcb8d to ecfcb3b Compare December 31, 2024 00:53
@DaniPopes DaniPopes force-pushed the dani/more-deterministic-benches branch from ecfcb3b to 8da1db5 Compare December 31, 2024 01:04
@DaniPopes DaniPopes requested a review from klkvr as a code owner December 31, 2024 01:04
Rjected
Rjected approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@DaniPopes DaniPopes added this pull request to the merge queue Dec 31, 2024
Merged via the queue into main with commit 9a062c0 Dec 31, 2024
45 checks passed
@DaniPopes DaniPopes deleted the dani/more-deterministic-benches branch December 31, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make benchmark inputs deterministic
2 participants
@DaniPopes @Rjected