Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct vars #13567

Merged
merged 1 commit into from
Dec 27, 2024
Merged

fix: use correct vars #13567

merged 1 commit into from
Dec 27, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 27, 2024

Hit footgun with param order...

/// Decodes the `eip1559` parameters from the `extradata` bytes.
///
/// Returns (`elasticity`, `denominator`)
pub fn decode_holocene_extra_data(extra_data: &[u8]) -> Result<(u32, u32), EIP1559ParamError> {

@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Dec 27, 2024
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP, should we have made this method return a base fee param struct?

@mattsse
Copy link
Collaborator Author

mattsse commented Dec 27, 2024

yeah, or ideally the order in which these params are encoded, which is the other way around.

very bad -.-

@mattsse mattsse merged commit bc8d4fe into main Dec 27, 2024
44 checks passed
@mattsse mattsse deleted the matt/fix-holocene-basefee branch December 27, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants