Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make clippy happy #13561

Merged
merged 1 commit into from
Dec 27, 2024
Merged

chore: make clippy happy #13561

merged 1 commit into from
Dec 27, 2024

Conversation

fgimenez
Copy link
Member

fixes errors like these with latest clippy:

warning: useless conversion to the same type: `reth_errors::ProviderError`
    --> crates/storage/provider/src/providers/database/provider.rs:1046:81
     |
1046 |                   self.cursor_read_collect::<tables::Headers<Self::Header>>(range).map_err(Into::into)
     |  _________________________________________________________________________________-^^^^^^^^^^^^^^^^^^^
1047 | |             },
     | |____________- help: consider removing
     |

and

warning: this looks like a formatting argument but it is not part of a formatting macro
   --> crates/exex/exex/src/wal/storage.rs:122:70
    |
122 |                 self.read_notification(id)?.ok_or_eyre("notification {id} not found")?;
    |                                                                      ^^^^
    |

@fgimenez fgimenez added the C-debt Refactor of code section that is hard to understand or maintain label Dec 27, 2024
@fgimenez fgimenez enabled auto-merge December 27, 2024 09:34
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I think these are all left overs from upgrading alloy that clippy wasn't able to catch

@fgimenez fgimenez added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit df294e4 Dec 27, 2024
44 checks passed
@fgimenez fgimenez deleted the fgimenez/clippy-happy branch December 27, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants