perf: query accounts with &Address to avoid copying address
#13554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai-rise
commented
Dec 25, 2024
| @@ -367,7 +367,7 @@ where | |||
| let state = maybe_state.as_deref().expect("provider is set"); | |||
|
|
|||
| // Use provider to get account info | |||
| let account = match state.basic_account(transaction.sender()) { | |||
| let account = match state.basic_account(transaction.sender_ref()) { | |||
hai-rise
commented
Dec 25, 2024
| fn basic_account(&self, address: Address) -> ProviderResult<Option<Account>> { | ||
| Ok(self.tx.get::<tables::PlainAccountState>(address)?) | ||
| fn basic_account(&self, address: &Address) -> ProviderResult<Option<Account>> { | ||
| Ok(self.tx.get_by_encoded_key::<tables::PlainAccountState>(address)?) |
There was a problem hiding this comment.
makes sense to avoid the copy here
hai-rise
commented
Dec 25, 2024
| fn basic_account(&self, address: Address) -> ProviderResult<Option<Account>> { | ||
| self.tx().get::<tables::PlainAccountState>(address).map_err(Into::into) | ||
| fn basic_account(&self, address: &Address) -> ProviderResult<Option<Account>> { | ||
| self.tx().get_by_encoded_key::<tables::PlainAccountState>(address).map_err(Into::into) |
CodSpeed Performance ReportMerging #13554 will improve performances by 10.48%Comparing Summary
Benchmarks breakdown
|
mattsse
approved these changes
Dec 25, 2024
| fn basic_account(&self, address: Address) -> ProviderResult<Option<Account>> { | ||
| Ok(self.tx.get::<tables::PlainAccountState>(address)?) | ||
| fn basic_account(&self, address: &Address) -> ProviderResult<Option<Account>> { | ||
| Ok(self.tx.get_by_encoded_key::<tables::PlainAccountState>(address)?) |
There was a problem hiding this comment.
makes sense to avoid the copy here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #13171 towards #12838.