Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing from impls #13527

Merged
merged 1 commit into from
Dec 23, 2024
Merged

feat: add missing from impls #13527

merged 1 commit into from
Dec 23, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 23, 2024

will add a separate issue so we can also add all of those from/to impls to reth-ethereum-primitives transaction.

the unreachable can be removed after

alloy-rs/alloy#1842

@mattsse mattsse enabled auto-merge December 23, 2024 19:36
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #13527 will not alter performance

Comparing matt/add-missing-from-impl3 (812b96e) with main (3e15ae3)

Summary

✅ 73 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main matt/add-missing-from-impl3 Change
⁉️ `prefix set preload size: 1000 input size: 1000 BTreeSet with BTreeSet:range lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 BTreeSet with Iterator:any lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
🆕 `prefix set preload size: 1000 input size: 997 BTreeSet with BTreeSet:range lookup`
🆕 `prefix set preload size: 1000 input size: 997 BTreeSet with Iterator:any lookup`
🆕 `prefix set preload size: 1000 input size: 997 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 997 Vec with custom cursor lookup`

@mattsse mattsse added this pull request to the merge queue Dec 23, 2024
@mattsse mattsse added the A-sdk Related to reth's use as a library label Dec 23, 2024
Merged via the queue into main with commit 4c1208e Dec 23, 2024
43 of 44 checks passed
@mattsse mattsse deleted the matt/add-missing-from-impl3 branch December 23, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants