Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relax eth_callBundle bounds #13485

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 20, 2024

Relaxes bounds for EthCallBundle API by using EthPoolTransaction methods to get and validate blobs for any pooled transactions.

This is not perfect but should be OK while we are embedding 4844 logic into pool abstraction

Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #13485 will not alter performance

Comparing klkvr/relax-eth-bundle-bounds (621348e) with main (d217c67)

Summary

✅ 69 untouched benchmarks
🆕 8 new benchmarks
⁉️ 8 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main klkvr/relax-eth-bundle-bounds Change
🆕 range lookup` N/A 53.6 µs N/A
🆕 any lookup` N/A 199.8 µs N/A
🆕 `prefix set preload size: 100 input size: 100 Vec with binary search lookup`
🆕 `prefix set preload size: 100 input size: 100 Vec with custom cursor lookup`
⁉️ range lookup` 52.5 µs N/A N/A
⁉️ any lookup` 192 µs N/A N/A
⁉️ `prefix set preload size: 100 input size: 98 Vec with binary search lookup`
⁉️ `prefix set preload size: 100 input size: 98 Vec with custom cursor lookup`
🆕 range lookup` N/A 614.6 µs N/A
🆕 any lookup` N/A 20.1 ms N/A
🆕 `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
⁉️ range lookup` 611.7 µs N/A N/A
⁉️ any lookup` 19.5 ms N/A N/A
⁉️ `prefix set preload size: 1000 input size: 999 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 999 Vec with custom cursor lookup`

@mattsse mattsse merged commit a163a5c into main Dec 22, 2024
43 of 44 checks passed
@mattsse mattsse deleted the klkvr/relax-eth-bundle-bounds branch December 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants