Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(trie): parallel storage proof should not error on closed recv #13448

Merged
merged 2 commits into from
Jan 6, 2025
Merged

chore(trie): parallel storage proof should not error on closed recv #13448

merged 2 commits into from
Jan 6, 2025

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Dec 19, 2024 •
edited
Loading

reth/crates/trie/parallel/src/proof.rs

Lines 199 to 201 in b98cb87

// We can have the receiver dropped before we send, because we still calculate
// storage proofs for deleted accounts, but do not actually walk over them in
// `account_node_iter` below.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-observability Related to tracing, metrics, logs and other observability tools A-trie Related to Merkle Patricia Trie implementation labels Dec 19, 2024
@shekhirin shekhirin force-pushed the alexey/parallel-proof-error branch from a368452 to 07a4f26 Compare December 19, 2024 09:57
@shekhirin shekhirin force-pushed the alexey/parallel-proof-error branch from 9802518 to b98cb87 Compare January 6, 2025 10:43
@shekhirin shekhirin enabled auto-merge January 6, 2025 10:49
@shekhirin shekhirin added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 49d1b50 Jan 6, 2025
43 checks passed
@shekhirin shekhirin deleted the alexey/parallel-proof-error branch January 6, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @rkrasiuk