Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(engine): refactor code to transform EvmState into HashedPostState #13207

Merged
merged 2 commits into from
Dec 7, 2024
Merged

chore(engine): refactor code to transform EvmState into HashedPostState #13207

merged 2 commits into from
Dec 7, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Dec 7, 2024

Uses the same logic to transform EvmState -> HashedPostState in StateRootTask::on_state_update and tests.

@fgimenez fgimenez requested a review from shekhirin December 7, 2024 11:52
@fgimenez fgimenez added C-enhancement New feature or request A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Dec 7, 2024
mattsse
mattsse approved these changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
alternatively a single function would also be possible, but maybe we need that somewhere else?

@fgimenez
Copy link
Member Author

fgimenez commented Dec 7, 2024

alternatively a single function would also be possible, but maybe we need that somewhere else?

yep good point, i was planning to use it in #13212 too but finally not needed, changed to local function

@fgimenez fgimenez enabled auto-merge December 7, 2024 13:01
@fgimenez fgimenez added this pull request to the merge queue Dec 7, 2024
Merged via the queue into main with commit 828ddba Dec 7, 2024
41 checks passed
@fgimenez fgimenez deleted the fgimenez/refactor-srt-test branch December 7, 2024 13:26
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
@fgimenez @lean-apple
chore(engine): refactor code to transform EvmState into HashedPostSta…
fa5d34f 
…te (paradigmxyz#13207)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgimenez @mattsse