Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bound NetworkPrimitives types by proper traits #13196

Merged
merged 1 commit into from
Dec 9, 2024
Merged

feat: bound NetworkPrimitives types by proper traits #13196

merged 1 commit into from
Dec 9, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 6, 2024

Removes some redundant trait bounds captured by existing bounds, also uses BlockBody for the body, and SignedTransaction for the broadcasted transaction

@Rjected Rjected added A-networking Related to networking in general A-sdk Related to reth's use as a library labels Dec 6, 2024
@Rjected Rjected added the C-enhancement New feature or request label Dec 6, 2024
@Rjected Rjected force-pushed the dan/bound-primitives-traits branch from 80e49a4 to 82af8d3 Compare December 6, 2024 21:31
@mattsse mattsse added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit d68d7c8 Dec 9, 2024
41 checks passed
@mattsse mattsse deleted the dan/bound-primitives-traits branch December 9, 2024 11:29
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
@Rjected @lean-apple
feat: bound NetworkPrimitives types by proper traits (paradigmxyz#13196)
377c3a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-networking Related to networking in general A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse