perf(AllTransactions-iter): do not clone all transactions by default
#13187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Dec 6, 2024
Comment on lines
+1101
to
+1102
| ) -> impl Iterator<Item = &Arc<ValidPoolTransaction<T>>> + '_ { | ||
| self.by_hash.values() |
This was referenced Dec 6, 2024
lean-apple
pushed a commit
to lean-apple/reth
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're spamming the mempool so hard it can take over 1s for
TxPool::on_canonical_state_changeto complete. This needs much improvement for chains with 200ms-1s block time.Earlier profiling shows that ~10% is spent on cloning all transactions (via
AllTransactions::transactions_iter) to count the transaction type inupdate_transaction_type_metrics.And another 4% is spent on dropping the cloned
Arcs.We only need a reference for
tx.transaction.tx_type(), so this PR makestransactions_iterreturn references by default and only clone on demand like inpooled_transactions.