Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: push job front of queue #13177

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix: push job front of queue #13177

merged 1 commit into from
Dec 6, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 6, 2024

could be the cause for #13163 but not 100% sure

this was even noted correctly in the comment, we must push the job front of the queue, not back because this would mess up the order.

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-exex Execution Extensions labels Dec 6, 2024
shekhirin
shekhirin approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM

@mattsse mattsse enabled auto-merge December 6, 2024 10:37
@mattsse mattsse added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit ab87f22 Dec 6, 2024
42 checks passed
@mattsse mattsse deleted the matt/push-next-job-front branch December 6, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-exex Execution Extensions C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @shekhirin