fix: throw error if genesis header found on static files, but empty db #13157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Dec 5, 2024
| // database. Since `factory.block_hash` will only query the static files, we need to | ||
| // make sure that our database has been written to, and throw error if it's empty. | ||
| if factory.get_stage_checkpoint(StageId::Headers)?.is_none() { | ||
| return Err(InitStorageError::UninitializedDatabase) |
There was a problem hiding this comment.
can we log an error here so in case this happens we know where this is thrown?
mattsse
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13136
closes #11934
Some users will at times attempt to re-sync from scratch by just deleting the database. Since
factory.block_hashwill only query the static files, we need to make sure that our database has been written to, and throw error if it's empty.Otherwise, it will proceed and eventually fail on the
ExecutionStage, after going through a lengthySenderRecoveryStage