Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wire network primitives to remaining components #13143

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 4, 2024

This completes using NetworkPrimitives generics instead of default types for:

  • TransactionsManager,
  • NetworkConfig,
  • NetworkBuilder,
  • EthRequestHandler,
  • The NetworkEventListenerProvider impl on NetworkHandle,
  • and the RethNetworkConfig impl on RethNetworkConfig

There are many other additions of EthNetworkPrimitives in places that would be required if we were to remove default generics from these types, mostly in tests.

@Rjected Rjected added C-enhancement New feature or request A-networking Related to networking in general A-sdk Related to reth's use as a library labels Dec 4, 2024
@Rjected Rjected enabled auto-merge December 4, 2024 22:37
@Rjected Rjected added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 1f6b7d1 Dec 4, 2024
41 checks passed
@Rjected Rjected deleted the dan/wire-network-primitives branch December 4, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants