Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bound most NetworkBuilder methods by NetworkPrimitives generic #13119

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore: bound most NetworkBuilder methods by NetworkPrimitives generic #13119

merged 1 commit into from
Dec 4, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 3, 2024

This bounds NetworkBuilder methods by its NetworkPrimitives generic, except for transactions, which requires NetworkEventListenerProvider generics. Also adds a concrete EthNetworkPrimitives to the pooled_transactions test.

@Rjected Rjected added C-enhancement New feature or request A-networking Related to networking in general A-sdk Related to reth's use as a library labels Dec 3, 2024
@klkvr klkvr added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit d164e3e Dec 4, 2024
42 checks passed
@klkvr klkvr deleted the dan/bound-networkbuilder-methods branch December 4, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@emhane emhane Awaiting requested review from emhane

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @klkvr