Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make TransactionsManager Future impl generic over NetworkPrimitives #13115

Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat: make TransactionsManager Future impl generic over NetworkPrimitives #13115

merged 1 commit into from
Dec 3, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 3, 2024

This also makes some of the fetcher data structures and implementation generic over NetworkPrimitives. Introduces the SignedTransaction bound on the PooledTransaction type in NetworkPrimitives.

@Rjected Rjected added C-enhancement New feature or request A-networking Related to networking in general A-sdk Related to reth's use as a library labels Dec 3, 2024
@Rjected Rjected force-pushed the dan/transactionsmanager-future-generic branch from 1172282 to 458e1c5 Compare December 3, 2024 21:15
mattsse
mattsse approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go

Introduces the SignedTransaction bound on the PooledTransaction type

makes sense

@Rjected Rjected added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 601e8b9 Dec 3, 2024
41 checks passed
@Rjected Rjected deleted the dan/transactionsmanager-future-generic branch December 3, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-networking Related to networking in general A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse