Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make StaticFileProvider generic over NodePrimitives #12565

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat: make StaticFileProvider generic over NodePrimitives #12565

merged 1 commit into from
Nov 15, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Nov 15, 2024

Adds NodePrimitives generic to types reading or writing to staticfiles. We are still reading/writing concrete types but this should unblock turning those into generics

@klkvr klkvr changed the title feat: make StaticFileProvider generic over NodePrimitives feat: make StaticFileProvider generic over NodePrimitives Nov 15, 2024
@klkvr klkvr added A-static-files Related to static files A-sdk Related to reth's use as a library labels Nov 15, 2024
mattsse
mattsse approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@mattsse mattsse added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@klkvr klkvr added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@klkvr klkvr added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 72a52d5 Nov 15, 2024
42 checks passed
@klkvr klkvr deleted the klkvr/static-primitives branch November 15, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library A-static-files Related to static files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse