Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rm unused error variants #12499

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore: rm unused error variants #12499

merged 1 commit into from
Nov 13, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 13, 2024

these are unused and not very useful to begin with.

all non standard errors should go into other

@mattsse mattsse requested a review from Rjected as a code owner November 13, 2024 01:46
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Nov 13, 2024
rkrasiuk
rkrasiuk approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending CI rerun

@mattsse mattsse merged commit 5c62d68 into main Nov 13, 2024
36 of 41 checks passed
@mattsse mattsse deleted the matt/rm-unused-variants-payload-builder-error branch November 13, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk