Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): define new BlockHeader trait #12452

Merged
merged 2 commits into from
Nov 11, 2024
Merged

chore(sdk): define new BlockHeader trait #12452

merged 2 commits into from
Nov 11, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Nov 11, 2024

Use alloy_consensus::BlockHeader as super trait. Intends to replace the first draft of a block header trait in same crate.

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Nov 11, 2024
mattsse
mattsse approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

crates/evm/src/lib.rs Outdated Show resolved Hide resolved
@emhane emhane force-pushed the emhane/block-header branch from d92cc0e to 04db712 Compare November 11, 2024 16:05
@emhane emhane enabled auto-merge November 11, 2024 16:05
@emhane emhane added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 11fd5aa Nov 11, 2024
40 checks passed
@emhane emhane deleted the emhane/block-header branch November 11, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse