Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): make ExecutionOutcome generic over receipt #12448

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Nov 11, 2024

Based on #12447

Closes #11108, ref #12358

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Nov 11, 2024
@github-actions github-actions bot added A-consensus Related to the consensus engine A-execution Related to the Execution and EVM A-op-reth Related to Optimism and op-reth labels Nov 11, 2024
@emhane emhane changed the base branch from main to emhane/receipt-generic November 11, 2024 12:34
Base automatically changed from emhane/receipt-generic to main November 11, 2024 13:26
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, smol doc nit

crates/primitives-traits/src/receipt.rs Outdated Show resolved Hide resolved
emhane and others added 2 commits November 12, 2024 11:13
Co-authored-by: Federico Gimenez <fgimenez@users.noreply.github.com>
@emhane emhane enabled auto-merge November 12, 2024 10:21
@emhane emhane added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit b5f7eca Nov 12, 2024
41 checks passed
@emhane emhane deleted the emhane/execution-outcome-generic branch November 12, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine A-execution Related to the Execution and EVM A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ExecutionOutcome generic over receipt collection type
2 participants