-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(engine): add StateRootTask skeleton #12305
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
//! State root task related functionality. | ||
|
||
use reth_provider::providers::ConsistentDbView; | ||
use reth_trie::{updates::TrieUpdates, TrieInput}; | ||
use reth_trie_parallel::parallel_root::ParallelStateRootError; | ||
use revm_primitives::{EvmState, B256}; | ||
use std::{ | ||
future::Future, | ||
pin::Pin, | ||
sync::Arc, | ||
task::{Context, Poll}, | ||
}; | ||
use tokio_stream::wrappers::UnboundedReceiverStream; | ||
|
||
/// Standalone task that receives a transaction state stream and updates relevant | ||
/// data structures to calculate state root. | ||
/// | ||
/// It is responsile of initializing a blinded sparse trie and subscribe to | ||
/// transaction state stream. As it receives transaction execution results, it | ||
/// fetches the proofs for relevant accounts from the database and reveal them | ||
/// to the tree. | ||
/// Then it updates relevant leaves according to the result of the transaction. | ||
#[allow(dead_code)] | ||
pub(crate) struct StateRootTask<Factory> { | ||
/// View over the state in the database. | ||
consistent_view: ConsistentDbView<Factory>, | ||
/// Incoming state updates. | ||
state_stream: UnboundedReceiverStream<EvmState>, | ||
/// Latest trie input. | ||
input: Arc<TrieInput>, | ||
} | ||
|
||
#[allow(dead_code)] | ||
impl<Factory> StateRootTask<Factory> { | ||
/// Creates a new `StateRootTask`. | ||
pub(crate) const fn new( | ||
consistent_view: ConsistentDbView<Factory>, | ||
input: Arc<TrieInput>, | ||
state_stream: UnboundedReceiverStream<EvmState>, | ||
) -> Self { | ||
Self { consistent_view, state_stream, input } | ||
} | ||
|
||
/// Handles state updates. | ||
pub(crate) fn on_state_update(&self, _update: EvmState) { | ||
// TODO: calculate hashed state update and dispatch proof gathering for it. | ||
} | ||
} | ||
|
||
impl<Factory> Future for StateRootTask<Factory> { | ||
type Output = Result<(B256, TrieUpdates), ParallelStateRootError>; | ||
|
||
fn poll(self: Pin<&mut Self>, _cx: &mut Context<'_>) -> Poll<Self::Output> { | ||
// TODO: | ||
// * poll incoming state updates stream | ||
// * keep track of proof calculation | ||
// * keep track of intermediate root computation | ||
Poll::Pending | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still something we want to retain in our new designs? I thought the consistent db viewer was a 'hack' and we were looking for ways to do this better? Maybe I misremember