feat: restructure op builder #12229
Merged
feat: restructure op builder #12229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69ecdfd to
c805e2c
Compare
klkvr
approved these changes
Nov 4, 2024
| @@ -152,7 +811,7 @@ where | |||
| /// and configuration, this function creates a transaction payload. Returns | |||
| /// a result indicating success with the payload or an error in case of failure. | |||
| #[inline] | |||
| pub(crate) fn optimism_payload<EvmConfig, Pool, Client>( | |||
| pub fn optimism_payload<EvmConfig, Pool, Client>( | |||
There was a problem hiding this comment.
yep, will remove before merging
| // Configure the environment for the block. | ||
| let mut evm = self.evm_config.evm_with_env(&mut *db, env); | ||
|
|
||
| let ResultAndState { result, state } = match evm.transact() { |
There was a problem hiding this comment.
could we unify paths here for execution of sequencer and non-sequencer transactions?
There was a problem hiding this comment.
yep, I'd like that, but separately, wanted to keep it as similar to the previous version as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #11073
closes #11040
This refactors how the OP payload is being constructed.
Introduces a new
Ctxtype that provides reusable logic for transacting.This now also makes it possible easily modify how new txs are getting included int the block