Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): remove deprecated code for importing ovm chain #12181

Closed
wants to merge 2 commits into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Oct 30, 2024

Removes code that remains from when ovm chain was imported via pipeline

@emhane emhane added the C-debt Refactor of code section that is hard to understand or maintain label Oct 30, 2024
@emhane emhane requested a review from Rjected as a code owner October 30, 2024 08:11
@emhane emhane added A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library labels Oct 30, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

but we still kinda support pre bedrock import, wouldn't this break @joshieDo ?
or are we dropping support for this because a pain to maintain?

@joshieDo
Copy link
Collaborator

afaik we still support it, the receipt import was fixed here: #11216

but i'd be more than happy to drop support for importing prebedrock. But if so, we should remove it from the cli first

@emhane
Copy link
Member Author

emhane commented Oct 30, 2024

cool

but we still kinda support pre bedrock import, wouldn't this break @joshieDo ? or are we dropping support for this because a pain to maintain?

ah yes, thanks @mattsse , we can make a separate reth_downloaders::file_codec::BlockFileCodec for op mainnet import then, will open issue

@emhane emhane mentioned this pull request Oct 30, 2024
@emhane
Copy link
Member Author

emhane commented Nov 4, 2024

blocked by #12521

@emhane emhane added the S-blocked This cannot more forward until something else changes label Nov 4, 2024
@emhane emhane closed this Nov 20, 2024
@emhane emhane deleted the emhane/rm-deprecated-code branch November 20, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain S-blocked This cannot more forward until something else changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants