Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use net::discv5 for reth's discv5 tracing target namespace (reverts #12045) #12151

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

zilayo
Copy link
Contributor

@zilayo zilayo commented Oct 28, 2024

The tracing target for Reth's discv5 logs was changed from net::discv5 to discv5 in PR #12045 (fixed issue #12043)

Currently none of these traces are logged as there is a default directive discv5=off which is applied from DEFAULT_ENV_FILTER_DIRECTIVES. These are applied after the directives from RUST_LOG, so even if RUST_LOG=discv5=trace is used, this is overridden with discv5=off

const DEFAULT_ENV_FILTER_DIRECTIVES: [&str; 5] = [
"hyper::proto::h1=off",
"trust_dns_proto=off",
"trust_dns_resolver=off",
"discv5=off",
"jsonrpsee-server=off",
];

The discv5 external crate traces were initially disabled in PR #7458 due to noise.

This PR simply removes discv5=off from DEFAULT_ENV_FILTER_DIRECTIVES.

If it's still deemed that the discv5 external crate logs are too verbose and that this should remain turned off, then #12045 will need to be reverted or reth's discv5 crate target renamed.

@zilayo zilayo requested a review from onbjerg as a code owner October 28, 2024 22:49
@mattsse
Copy link
Collaborator

mattsse commented Oct 28, 2024

If it's still deemed that the discv5 external crate logs are too verbose and that this should remain turned off, then #12045 will need to be reverted or reth's discv5 crate target renamed.

ah right, that's why we used the net prefix in the first place.
the discv5 crate has a bunch of warns that we don't really want, so we should rather revert #12045

do you want to revert #12045 instead?

…yz#12045)"

This reverts commit 674616c.

The discv5 crate logs are too verbose, so reth's discv5 tracing target needs a seperate namespace.
@zilayo
Copy link
Contributor Author

zilayo commented Oct 28, 2024

If it's still deemed that the discv5 external crate logs are too verbose and that this should remain turned off, then #12045 will need to be reverted or reth's discv5 crate target renamed.

ah right, that's why we used the net prefix in the first place. the discv5 crate has a bunch of warns that we don't really want, so we should rather revert #12045

do you want to revert #12045 instead?

#12045 has been reverted and i renamed a few stragglers from discv5 -> net::discv5

@zilayo zilayo changed the title fix: remove default discv5 tracing filter directive fix: use net::discv5 for reth's discv5 tracing target namespace (reverts #12045) Oct 28, 2024
@mattsse mattsse enabled auto-merge October 28, 2024 23:46
@mattsse mattsse added this pull request to the merge queue Oct 28, 2024
Merged via the queue into paradigmxyz:main with commit 0297b8f Oct 29, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants