fix: use net::discv5 for reth's discv5 tracing target namespace (reverts #12045) #12151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tracing target for Reth's discv5 logs was changed from
net::discv5
todiscv5
in PR #12045 (fixed issue #12043)Currently none of these traces are logged as there is a default directive
discv5=off
which is applied fromDEFAULT_ENV_FILTER_DIRECTIVES
. These are applied after the directives fromRUST_LOG
, so even ifRUST_LOG=discv5=trace
is used, this is overridden withdiscv5=off
reth/crates/tracing/src/layers.rs
Lines 22 to 28 in ddc9bda
The discv5 external crate traces were initially disabled in PR #7458 due to noise.
This PR simply removes
discv5=off
fromDEFAULT_ENV_FILTER_DIRECTIVES
.If it's still deemed that the
discv5
external crate logs are too verbose and that this should remain turned off, then #12045 will need to be reverted or reth's discv5 crate target renamed.