Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invoke prometheus recorder on op-reth Cli::run #11982

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: invoke prometheus recorder on op-reth Cli::run #11982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bin/reth/src/cli/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ impl<C: ChainSpecParser<ChainSpec = ChainSpec>, Ext: clap::Args + fmt::Debug> Cl
let _guard = self.init_tracing()?;
info!(target: "reth::cli", "Initialized tracing, debug log directory: {}", self.logs.log_file_directory);

// Install the prometheus recorder to be sure to record task
// executor's metrics
// Install the prometheus recorder to be sure to record all metrics
let _ = install_prometheus_recorder();

let runner = CliRunner::default();
Expand Down
4 changes: 4 additions & 0 deletions crates/optimism/cli/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ use tracing::info;
// This allows us to manually enable node metrics features, required for proper jemalloc metric
// reporting
use reth_node_metrics as _;
use reth_node_metrics::recorder::install_prometheus_recorder;

/// The main op-reth cli interface.
///
Expand Down Expand Up @@ -135,6 +136,9 @@ where
let _guard = self.init_tracing()?;
info!(target: "reth::cli", "Initialized tracing, debug log directory: {}", self.logs.log_file_directory);

// Install the prometheus recorder to be sure to record all metrics
let _ = install_prometheus_recorder();

let runner = CliRunner::default();
match self.command {
Commands::Node(command) => {
Expand Down
Loading