Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metrics): remove redundant starting metrics log #11621

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Oct 9, 2024

We have two of these logs that appear on startup, one in node builder and one in serve .

Now this is only in node builder:

info!(target: "reth::cli", "Starting metrics endpoint at {}", addr);

@Rjected Rjected added C-enhancement New feature or request A-observability Related to tracing, metrics, logs and other observability tools labels Oct 9, 2024
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

@mattsse mattsse added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 701f51b Oct 10, 2024
38 checks passed
@mattsse mattsse deleted the dan/remove-redundant-metrics-log branch October 10, 2024 01:35
vandenbogart pushed a commit to testmachine-ai/reth that referenced this pull request Oct 14, 2024
reymom pushed a commit to reymom/reth that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants