test(db): cursor write operations are working properly wherever cursor is #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinsankim
commented
Feb 3, 2023
| let key_to_insert = 2; | ||
| let tx = db.tx_mut().expect(ERROR_INIT_TX); | ||
| let mut cursor = tx.cursor_write::<CanonicalHeaders>().unwrap(); | ||
|
|
||
| // INSERT | ||
| cursor.seek_exact(1).unwrap(); |
There was a problem hiding this comment.
note: seek is not needed.
jinsankim
commented
Feb 3, 2023
| @@ -378,9 +444,16 @@ mod tests { | |||
| let key_to_append = 2; | |||
| let tx = db.tx_mut().expect(ERROR_INIT_TX); | |||
| let mut cursor = tx.cursor_write::<CanonicalHeaders>().unwrap(); | |||
| cursor.seek_exact(1).unwrap(); | |||
There was a problem hiding this comment.
note: seek is not needed.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1161 +/- ##
==========================================
+ Coverage 74.73% 74.84% +0.11%
==========================================
Files 333 333
Lines 35449 35517 +68
==========================================
+ Hits 26492 26584 +92
+ Misses 8957 8933 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gakonst
approved these changes
Feb 3, 2023
|
@jinsankim thank you for this! I had wrong thinking about what |
literallymarvellous
pushed a commit
to literallymarvellous/reth
that referenced
this pull request
Feb 6, 2023
ensi321
pushed a commit
to ensi321/reth
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related w/ #1130 (comment)
Motivation