chore(net): support multiple eth protocol versions.

[jinsankim]

Closes #1101

Motivation

we're announcing support for eth66/67 by default in Hello but only check for a single version in the eth Status handshake

Direction

we add a list of versions as a separate parameter to the handshake function

Alternative idea to direction

• overwrite SharedCapability::Eth.version to Status.version

Note

• geth negotiates eth protocol and it selects highest version.
  https://github.com/ethereum/go-ethereum/blob/d0a4989a8def7e6bad182d1513e8d4a093c1672d/cmd/devp2p/internal/ethtest/helpers.go#L130-L132
• We also already have the same logic at
  

  reth/crates/net/eth-wire/src/p2pstream.rs

  Lines 562 to 567 in a55e7fd

  	if version.is_none() ||
  	(version.is_some() && peer_capability.version > *version.expect("is some; qed"))
  	{
  	shared_capabilities.insert(peer_capability.name.clone(), peer_capability.version);
  	shared_capability_names.insert(peer_capability.name);
  	}

• With this simple change, I'm success to handshake w/ Eth66.
• I expect it might mitigate the MismatchedProtocolVersion issue before Support for multiple devp2p capabilities #791 is completed.

[mattsse]

ty

pending @Rjected

[mattsse]

this looks correct.

[gakonst]

please add a test for this, agree with the fix, testing the PR now

[jinsankim]

please add a test for this, agree with the fix, testing the PR now

follow it up w/ b4d6880

[codecov-commenter]

Codecov Report

Merging #1152 (b4d6880) into main (a55e7fd) will increase coverage by 0.51%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
+ Coverage   74.75%   75.27%   +0.51%     
==========================================
  Files         333      335       +2     
  Lines       35442    36373     +931     
==========================================
+ Hits        26495    27380     +885     
- Misses       8947     8993      +46     

Flag	Coverage Δ
unit-tests	75.27% <100.00%> (+0.51%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
crates/net/network/src/session/mod.rs	68.75% <ø> (+0.06%)	⬆️
crates/net/network/src/test_utils/testnet.rs	88.20% <100.00%> (+0.92%)	⬆️
crates/transaction-pool/src/test_utils/mock.rs	51.77% <0.00%> (-6.74%)	⬇️
crates/executor/src/revm_wrap.rs	38.21% <0.00%> (-1.79%)	⬇️
crates/net/network/src/session/active.rs	85.90% <0.00%> (-1.00%)	⬇️
crates/primitives/src/transaction/mod.rs	89.29% <0.00%> (-0.54%)	⬇️
crates/transaction-pool/src/pool/txpool.rs	58.82% <0.00%> (-0.51%)	⬇️
crates/stages/src/stages/bodies.rs	92.68% <0.00%> (-0.45%)	⬇️
crates/stages/src/stages/execution.rs	92.04% <0.00%> (-0.14%)	⬇️
crates/executor/src/executor.rs	93.76% <0.00%> (-0.13%)	⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.