-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add metrics to track transactions by type in txpool #11403
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,8 +36,18 @@ pub struct TxPoolMetrics { | |
/// Total amount of memory used by the transactions in the blob sub-pool in bytes | ||
pub(crate) blob_pool_size_bytes: Gauge, | ||
|
||
/// Number of all transactions of all sub-pools: pending + basefee + queued | ||
/// Number of all transactions of all sub-pools: pending + basefee + queued + blob | ||
pub(crate) total_transactions: Gauge, | ||
/// Number of all legacy transactions in the pool | ||
pub(crate) total_legacy_transactions: Gauge, | ||
/// Number of all EIP-2930 transactions in the pool | ||
pub(crate) total_eip2930_transactions: Gauge, | ||
/// Number of all EIP-1559 transactions in the pool | ||
pub(crate) total_eip1559_transactions: Gauge, | ||
/// Number of all EIP-4844 transactions in the pool | ||
pub(crate) total_eip4844_transactions: Gauge, | ||
/// Number of all EIP-7702 transactions in the pool | ||
pub(crate) total_eip7702_transactions: Gauge, | ||
Comment on lines
+49
to
+50
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This wasn't mentioned in the original issue but I assume we wanted to track all tx types so added here. |
||
|
||
/// How often the pool was updated after the canonical state changed | ||
pub(crate) performed_state_updates: Counter, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tidy this comment as blob sub-pool exists.