Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(hive): update expected rpc-compat failures #11367

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Oct 1, 2024

These tests expect non-checksummed versions of addresses in the RPC responses and we now return checksummed addresses:

>>  {"jsonrpc":"2.0","id":1,"method":"eth_getTransactionByHash","params":["0xbdb37c763e721bf1a0e94e0bc72db704110b2ccc6720713708744422a2cc95d6"]}
<<  {"jsonrpc":"2.0","id":1,"result":{"hash":"0xbdb37c763e721bf1a0e94e0bc72db704110b2ccc6720713708744422a2cc95d6","nonce":"0x0","blockHash":"0xac5c61edb087a51279674fe01d5c1f65eac3fd8597f9bea215058e745df8088e","blockNumber":"0x1","transactionIndex":"0x0","from":"0x7435ed30A8b4AEb0877CEf0c6E8cFFe834eb865f","to":null,"value":"0x0","gasPrice":"0x342770c1","gas":"0x131ec","input":"0x600d380380600d6000396000f360004381526020014681526020014181526020014881526020014481526020013281526020013481526020016000f3","r":"0xdf95c12446d276292221a19cca4f3e678f113a412bf3845bd85dc5bb5bd87def","s":"0x523b1712e2f5a7b421f5740d32f51fd33a525026a21fd89770a55480ad28732","v":"0x18e5bb3abd10a0","chainId":"0xc72dd9d5e883e","type":"0x0"}}
response differs from expected (-- client, ++ test):
 {
   "id": 1,
   "jsonrpc": "2.0",
   "result": {
     "blockHash": "0xac5c61edb087a51279674fe01d5c1f65eac3fd8597f9bea215058e745df8088e",
     "blockNumber": "0x1",
     "chainId": "0xc72dd9d5e883e",
-    "from": "0x7435ed30A8b4AEb0877CEf0c6E8cFFe834eb865f",
+    "from": "0x7435ed30a8b4aeb0877cef0c6e8cffe834eb865f",
     "gas": "0x131ec",
     "gasPrice": "0x342770c1",
     "hash": "0xbdb37c763e721bf1a0e94e0bc72db704110b2ccc6720713708744422a2cc95d6",
     "input": "0x600d380380600d6000396000f360004381526020014681526020014181526020014881526020014481526020013281526020013481526020016000f3",
     "nonce": "0x0",
     "r": "0xdf95c12446d276292221a19cca4f3e678f113a412bf3845bd85dc5bb5bd87def",
     "s": "0x523b1712e2f5a7b421f5740d32f51fd33a525026a21fd89770a55480ad28732",
     "to": null,
     "transactionIndex": "0x0",
     "type": "0x0",
     "v": "0x18e5bb3abd10a0",
     "value": "0x0"
   }
 }

@mattsse mattsse added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit bdbdb14 Oct 1, 2024
38 checks passed
@mattsse mattsse deleted the fgimenez/update-hive-expected-failures branch October 1, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants